feat(storybook): custom properties panel #3166
Draft
+945
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d497927 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
3 times, most recently
from
2ed616c
to
e1f7a95
Compare
castastrophe
added
skip_vrt
|
🚀 Deployed on https://pr-3166--spectrum-css.netlify.app |
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
e1f7a95
to
27b6165
Compare
File metricsSummaryTotal size: 4.30 MB* 🎉 No changes detected in any packages * Size determined by adding together the size of the main file for all packages in the library.* Results are not gzipped or minified. * An ASCII character in UTF-8 is 8 bits or 1 byte. |
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
7 times, most recently
from
754b512
to
59656d1
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
59656d1
to
4c2f600
Compare
castastrophe
force-pushed
the
feat-storybook-custom-properties-panel
branch
from
4c2f600
to
d497927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new custom properties panel to the development preview pages for each component that surfaces the modifiable custom properties as sourced from the metadata/metadata.json file (note that this is not a live updated list because metadata.json is not generated by storybook).
This panel allows a visitor to put in their own values and see how it impacts the styling of the component in the view panel.
How and where has this been tested?
Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.
Validation steps
--mod-accordion-background-color-defaultentry; expect to see the background color of the accordion to update live.To-do list